HTTPClient Port #347
Merged
HTTPClient Port #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove workaround of sockets always return -76 (because it's fixed on IDF now) Remove delay during handshake (improving stability)
Changed SHA1 fingerprint by Root CA verification Changed log system
igrr
reviewed
May 4, 2017
| bool begin(String host, uint16_t port, String uri = "/"); | ||
| bool begin(String host, uint16_t port, String uri, const char* CAcert); | ||
| // deprecated, use the overload above instead | ||
| bool begin(String host, uint16_t port, String uri, bool https, const char* CAcert) __attribute__ ((deprecated)); |
There was a problem hiding this comment.
What's the logic for adding a deprecated function, when adding a library for the first time?
|
I tried to keep it as closer possible to ESP8266 library, it stays so close that even the deprecated functions remain deprecated =P |
|
when is tihs going to be available in the master branch? |
|
@me-no-dev @igrr did you move away from https://github.com/arduino-libraries/ArduinoHttpClient ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed SHA1 fingerprint by Root CA verification
Changed log system
Some WiFIClientSecure fixes